TDS Codegen GlassV4 Templates Added Cachable#6
Open
nsgocev wants to merge 4 commits intoHedgehogDevelopment:masterfrom
Open
TDS Codegen GlassV4 Templates Added Cachable#6nsgocev wants to merge 4 commits intoHedgehogDevelopment:masterfrom
nsgocev wants to merge 4 commits intoHedgehogDevelopment:masterfrom
Conversation
|
Any chance we can go ahead and merge this? |
|
Nice, I would further add Name to the Header. I was surprised it wasn't in the original and wonder what the reasoning was to exclude it. Item Name is a pretty important thing... |
Contributor
|
I think Name should not be put into GlassBase, and also Url should be removed from it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.