Adding URL to GlassBase#5
Open
nsgocev wants to merge 1 commit intoHedgehogDevelopment:masterfrom
nsgocev:patch-2
Open
Adding URL to GlassBase#5nsgocev wants to merge 1 commit intoHedgehogDevelopment:masterfrom nsgocev:patch-2
nsgocev wants to merge 1 commit intoHedgehogDevelopment:masterfrom
nsgocev:patch-2
Conversation
URL is property which is almost always required. It will be nice to have it in the base T4 Templates
SaintSkeeta
requested changes
May 25, 2017
Contributor
SaintSkeeta
left a comment
SaintSkeeta
left a comment
There was a problem hiding this comment.
I request that we remove this from GlassBase..... we want GlassBase to be as slim as possible.... and only add URL to models that need it. With component-driven dev now....I believe this makes more sense....as there are a lot more items as data sources....that aren't actual pages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL is property which is almost always required. It will be nice to have it in the base T4 Templates