Update dependencies, logos, banner, and enhance UI with tests#154
Merged
Conversation
Update dependencies
Update logos, add banner, and enhance UI with tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request updates branding and icons throughout the application, improves platform-specific logo handling, and makes several UI and accessibility adjustments. The most significant changes include replacing old icons and logos with new, platform-specific assets, updating the logic for displaying the correct logo based on OS and theme, and refining the appearance and accessibility of toggle switches. There are also minor improvements to the finance API integration and a cleanup of font usage.
Branding and Asset Updates
icon.svg,logo.png,icon.png) with new, platform-specific assets (onefinance_icon_win_light.png,onefinance_icon_mac_light.png, etc.) in both the build configuration (electron-builder.json) and throughout the app for Windows, macOS, and Linux. [1] [2] [3] [4]Sidebar.vue,SettingsView.vue) to use new lockup images that adapt to platform (Windows/macOS) and theme (light/dark) via computed logic, replacing static imports and simplifying the logo display. [1] [2] [3] [4] [5]UI and Accessibility Improvements
Sidebar.vueandSettingsView.vuefor a cleaner look, removing redundant containers and text. [1] [2] [3]Finance API Integration
chart()method instead of the deprecatedhistorical()for fetching historical prices, improving reliability and future-proofing the code. [1] [2]Styling and Fonts
font-sansutility for better performance and consistency. [1] [2]