Update logos, add banner, and enhance UI with tests#141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request updates the application's branding assets and improves platform-specific icon handling across the codebase. It also refines several UI elements for better dark mode support and makes a minor fix to the Yahoo Finance API usage. The most significant changes are grouped below:
Branding and Icon Updates:
icon.svg,logo.png,icon.png) with new platform-specific icons and lockups (e.g.,onefinance_icon_win_light.png,onefinance_icon_mac_light.png, and corresponding lockup images). Electron builder configuration and asset references throughout the app have been updated to use these new files. (electron-builder.json,electron/main.ts,src/components/Sidebar.vue,src/views/settings/SettingsView.vue) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]src/components/Sidebar.vue,src/views/settings/SettingsView.vue) [1] [2] [3]Dark Mode and UI Improvements:
src/views/investments/components/PriceAlertModal.vue,src/views/recurring/RecurringView.vue,src/views/recurring/components/RecurringModal.vue,src/views/settings/SettingsView.vue) [1] [2] [3] [4] [5] [6] [7] [8]font-sansutility for font family, simplifying font management. (src/style.css) [1] [2]API and Data Handling:
historical()method withchart(), handling null-close rows manually and disabling schema validation to better accommodate Yahoo's API changes. (electron/finance.ts) [1] [2]These changes collectively modernize the app's appearance, improve cross-platform consistency, and address some technical debt in API usage and styling.