Open
Conversation
Zarithya
commented
May 24, 2024
- Fix the plugin's identifier to be app.warudo.streamdeck to comply with revers-DNS standards
- Fix localization file to not use placeholder text
- Clean some unnecessary code and files
- Update libs, .gitignore
- Prevent websocket from trying to connect without Warudo being open
- Show okay/alert icon when pressing a key
Contributor
|
Thanks for the PR! Do you know if Elgato will accept identifier changes as part of a plugin update? |
Author
|
No idea, I only started digging into this yesterday. |
Contributor
|
Lemme reach out and ask them! |
Author
|
Hey, any update with this? Hoping to see these fixes soon! |
Contributor
|
@Zarithya We submitted the update last month and still waiting for Elgato to approve it :( |
Contributor
|
Also, they replied that plugin identifiers cannot be changed, so I think that part of the commit needs to be reverted! |
Author
|
Hm I see, I'm guessing submitting as a new addon wouldn't work? I guess the identifier isn't too important, it just bugs me that it's not revers-DNS compliant 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.