Skip to content

Polish the plugin a bit#1

Open
Zarithya wants to merge 3 commits intoHakuyaLabs:masterfrom
Zarithya:polish
Open

Polish the plugin a bit#1
Zarithya wants to merge 3 commits intoHakuyaLabs:masterfrom
Zarithya:polish

Conversation

@Zarithya
Copy link

  • Fix the plugin's identifier to be app.warudo.streamdeck to comply with revers-DNS standards
  • Fix localization file to not use placeholder text
  • Clean some unnecessary code and files
  • Update libs, .gitignore
  • Prevent websocket from trying to connect without Warudo being open
  • Show okay/alert icon when pressing a key

@TigerHix
Copy link
Contributor

Thanks for the PR! Do you know if Elgato will accept identifier changes as part of a plugin update?

@Zarithya
Copy link
Author

No idea, I only started digging into this yesterday.

@TigerHix
Copy link
Contributor

Lemme reach out and ask them!

@Zarithya
Copy link
Author

Hey, any update with this? Hoping to see these fixes soon!

@TigerHix
Copy link
Contributor

@Zarithya We submitted the update last month and still waiting for Elgato to approve it :(

@TigerHix
Copy link
Contributor

Also, they replied that plugin identifiers cannot be changed, so I think that part of the commit needs to be reverted!

@Zarithya
Copy link
Author

Hm I see, I'm guessing submitting as a new addon wouldn't work? I guess the identifier isn't too important, it just bugs me that it's not revers-DNS compliant 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants