Camera preview overlay#222
Open
MoisesMlg wants to merge 2 commits into
Open
Conversation
added 2 commits
April 20, 2026 19:52
# Conflicts: # src/editor/pages/parts/viewport3D.cpp
Prazon
added a commit
to Prazon/pyrite64
that referenced
this pull request
May 11, 2026
…keep selection gate Replaces the duplicated PiP pass in viewport3D with upstream's renderScenePass(target, uni, drawEditorHelpers) split, and moves the projection-matrix math onto Comp::Camera (applyToGlobalUniforms / getAspectRatio) so future Camera fields don't have to be threaded through Spec/extractSpec. Fork-only behavior preserved: the preview is selection-gated (first selected Comp::Camera wins, with prefab-instance redirect through uuidPrefab), and the overlay keeps the icon+name label. Sprite scale is copied from the host viewport's uniGlobal after the helper runs. Also null-guards Camera::init's scene deref so component-describe works in the headless CLI path (no loaded scene at that point).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a camera preview overlay on the 3D viewport for objects with a Camera component.
I have thought about adding a ComboBox or arrows to switch between cameras in the scene, but I believe this is ok for a first version.