test: run full test suite in npm test, not just smoke tests#19
Open
dmchaledev wants to merge 1 commit into
Open
test: run full test suite in npm test, not just smoke tests#19dmchaledev wants to merge 1 commit into
dmchaledev wants to merge 1 commit into
Conversation
The npm test script ran only test/smoke.test.mjs (6 tests), so the 59-test calculate.test.mjs suite was never executed by CI. Switch to a glob (test/*.test.mjs) so all 65 tests run on every push and PR. https://claude.ai/code/session_01YCPuYtBp4RKGj2CqUp7Bq2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
npm testscript only rantest/smoke.test.mjs:That executes just 6 smoke tests. The comprehensive 59-test
test/calculate.test.mjssuite (added in #9, covering VM sizing, timing, costs, ROI, recommendations, and edge cases) was never run by CI, because CI invokesnpm test.Commit dafee26 claimed the test script was "updated to glob," but
package.jsonstill pointed at the single smoke file — so the calculation suite has been silently uncovered on every push and PR since.Fix
Switch the test script to a glob so all test files run:
Verification
Before —
npm test:After —
npm test:All 65 tests (6 smoke + 59 calculate) now pass and will run across the Node 18/20/22 CI matrix.
Note: the directory form
node --test test/was rejected on Node 22, so the explicit glob is used.https://claude.ai/code/session_01YCPuYtBp4RKGj2CqUp7Bq2
Generated by Claude Code