test: run all test files in npm test, not just smoke tests#15
Open
dmchaledev wants to merge 1 commit into
Open
test: run all test files in npm test, not just smoke tests#15dmchaledev wants to merge 1 commit into
dmchaledev wants to merge 1 commit into
Conversation
The npm test script only ran test/smoke.test.mjs (6 tests), so the 59 calculation tests added in dafee26 never executed in CI despite that commit's message stating the script was switched to a glob. Switch to test/*.test.mjs so all test files run. npm test now executes all 65 tests (6 smoke + 59 calculation), all passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
npm testscript only runstest/smoke.test.mjs:That's 6 tests. But the repo also has
test/calculate.test.mjswith 59 tests covering VM sizing, timing, costs, ROI analysis, recommendations, and edge cases — added indafee26. Those 59 tests have never run in CI, even though the commit message fordafee26stated the test script was switched to a glob (it wasn't — the script was never changed).The net effect: ~91% of the test suite (59 of 65 tests) is silently skipped on every push and PR. The calculation engine — the actual product logic — has zero CI coverage.
Fix
Switch the test script to a glob so all test files run:
Verification
Before (
main):After (this PR):
All 65 tests pass. No source or test files were modified — this only restores the existing-but-orphaned tests to the CI run. One-line change, fully self-contained.
https://claude.ai/code/session_01BknoASdgDLN3NPV1RmoHEv
Generated by Claude Code