Skip to content

fix: validate --timeout CLI arg to prevent silent NaN abort #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmchaledev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate --timeout CLI arg to prevent silent NaN abort #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,18 @@ async function main() {
}

const jsonMode = args.includes('--json');
const timeoutArg = args.find((a, i) => a === '--timeout' && args[i + 1]);
const timeoutMs = timeoutArg ? parseInt(args[args.indexOf('--timeout') + 1], 10) : undefined;
const url = args.find(a => !a.startsWith('--') && a !== String(timeoutMs));
const timeoutIdx = args.indexOf('--timeout');
const rawTimeout = timeoutIdx !== -1 ? args[timeoutIdx + 1] : undefined;
if (timeoutIdx !== -1 && (rawTimeout === undefined || rawTimeout.startsWith('--'))) {
console.error('Error: --timeout requires a value in milliseconds (e.g. --timeout 5000)');
process.exit(1);
}
const timeoutMs = rawTimeout !== undefined ? parseInt(rawTimeout, 10) : undefined;
if (timeoutMs !== undefined && (isNaN(timeoutMs) || timeoutMs <= 0)) {
console.error(`Error: --timeout value must be a positive integer in milliseconds (e.g. --timeout 5000), got: '${rawTimeout}'`);
process.exit(1);
}
const url = args.find(a => !a.startsWith('--') && a !== rawTimeout);
if (!url) {
console.error('Usage: security-headers <url> [--json] [--timeout ms] [--help] [--version]');
console.error('Run with --help for full usage information.');
Expand Down
Loading