feat(asm): add GET and DELETE /tags/{tag_id} to complete Tags CRUD#11
Open
dmchaledev wants to merge 1 commit into
Open
feat(asm): add GET and DELETE /tags/{tag_id} to complete Tags CRUD#11dmchaledev wants to merge 1 commit into
dmchaledev wants to merge 1 commit into
Conversation
Tags could be created but never retrieved individually or deleted, leaving the resource CRUD incomplete. Adds the missing path with a reusable TagId path parameter component and removes the tag from all carrying assets on delete (documented in the description). Also adds missing `description` fields to listTags and createTag for doc clarity. https://claude.ai/code/session_01JBue1nqjg6Apw8JCu9BGev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$(cat <<'EOF'
Problem
The Tags resource in
asm/openapi.yamlwas missingGET /tags/{tag_id}andDELETE /tags/{tag_id}. API consumers could create tags but had no way to fetch a single tag by ID or remove one — an incomplete CRUD contract that would force workarounds (e.g., filteringGET /tagsclient-side just to confirm a tag exists before deletion).Changes
GET /tags/{tag_id}— retrieve a single tag by IDDELETE /tags/{tag_id}— permanently delete a tag; description clarifies the tag is removed from all assets that carry itcomponents/parameters/TagId— reusable path parameter (mirrors the existingAssetIdpattern)descriptionfields tolistTagsandcreateTagoperations (they were the only two operations in the spec without one, which caused Spectraloas3-operation-descriptionwarnings)Test plan
spectral lint asm/openapi.yaml --ruleset spectral:oas --fail-severity warnpasses with no new warningsDELETE /tags/{tag_id}returns204on success and404when the tag ID doesn't existhttps://claude.ai/code/session_01JBue1nqjg6Apw8JCu9BGev
EOF
)
Generated by Claude Code