PR to solve the issue of messages mixing by HashirGJ8842 · Pull Request #53 · Haider8/tmessage

HashirGJ8842 · 2019-10-27T10:39:55Z

In this, I have done some changes to create a system of databases, with each user having their own
database.

In this edit, we can now create new databases for the users who have recently registered, and the messages sent by the users will be stored in their respective databases. I have used SQLAlchemy instead of peewee.

Just added a variable 'new' in line 65 and line 78. And a new argument named 'new'.

pep8speaks · 2019-10-27T10:39:58Z

Hello @HashirGJ8842! Thanks for updating this PR.

In the file tmessage/cli.py:

Line 8:33: E261 at least two spaces before inline comment

In the file tmessage/db.py:

Line 9:47: E261 at least two spaces before inline comment
Line 12:5: E303 too many blank lines (2)
Line 22:5: E303 too many blank lines (2)
Line 22:12: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 22:20: E261 at least two spaces before inline comment

Comment last updated at 2019-10-29 07:48:29 UTC

hound · 2019-10-27T10:39:58Z

tmessage/db.py


+User = ''
+class MessageDatabase(db.Model):
+    __bind_key__ = User 


trailing whitespace

hound · 2019-10-27T10:39:58Z

tmessage/db.py

+db = SQLAlchemy(app)

+User = ''
+class MessageDatabase(db.Model):


expected 2 blank lines, found 0

hound · 2019-10-27T10:39:58Z

tmessage/db.py

-from peewee import CharField, DateTimeField, Model, SqliteDatabase
+app = Flask(__name__)
+app.config['SQLALCHEMY_DATABASE_URI'] = 'sqlite:///main.db'
+app.config['SQLALCHEMY_BINDS'] = { 'we' : 'sqlite:///we.db'}


whitespace after '{'
whitespace before ':'

hound · 2019-10-27T10:54:24Z

tmessage/db.py

+pip install flask-sqlalchemy
 from datetime import datetime
+from flask import Flask
+from flask_sqlalchemy import SQLAlchemy


module level import not at top of file

hound · 2019-10-27T10:54:24Z

tmessage/db.py

+pip install flask
+pip install flask-sqlalchemy
 from datetime import datetime
+from flask import Flask


module level import not at top of file

hound · 2019-10-27T10:54:25Z

tmessage/db.py

@@ -1,28 +1,34 @@
 """Handles the connection to the SQLite database as well as DB interaction"""
+pip install flask


SyntaxError: invalid syntax

Haider8 · 2019-10-27T11:42:02Z

tmessage/db.py

+from flask_sqlalchemy import SQLAlchemy

-from peewee import CharField, DateTimeField, Model, SqliteDatabase
+app = Flask(__name__)


There's no need for flask in tmessage because we are not making a webserver here. Let us know on which issue are you working on or try opening a new issue if you want to work on some other issues.

Thanks for the PR though :)

I haven't used flask to make a webserver. I have used it so that I could use SqlAlchemy explicitly to work on this issue, and just because i was comfortable with SqlAlchemy ORM.

You don't need flask to use sqlalchemy and secondly, we are using peewee as an ORM

hound · 2019-10-27T16:24:37Z

tmessage/db.py


+class Message(DB.Model):
+    def fun(user):
+        __bind_key__ = user


local variable 'bind_key' is assigned to but never used

hound · 2019-10-27T16:44:14Z

tmessage/db.py

+def new_database(user):
+    APP.config['SQLALCHEMY_BINDS'][user] = f'sqlite:///{user}.db'
+
+


blank line contains whitespace

hound · 2019-10-27T16:44:14Z

tmessage/db.py

-@MESSAGES_DB
+def new_database(user):
+    APP.config['SQLALCHEMY_BINDS'][user] = f'sqlite:///{user}.db'
+


blank line contains whitespace

hound · 2019-10-27T18:38:31Z

tmessage/db.py

-    timestamp = DateTimeField()
+    def add(self):
+        return 1+1
+    def __repr__(self):


expected 1 blank line, found 0

hound · 2019-10-27T20:27:52Z

tmessage/db.py

+    def add(self):
+        """ To few methods"""
+        print(self.sender)
+


blank line contains whitespace

hound · 2019-10-27T20:49:26Z

tmessage/db.py

+    timestamp = DB.Column(DB.DateTime)
+
+
+    def __repr__(self):


too many blank lines (2)

hound · 2019-10-27T20:49:27Z

tmessage/db.py

+    sender = DB.Column(DB.String(120), primary_key=True, nullable=False)
+    message = DB.Column(DB.String(120), nullable=False)
+    timestamp = DB.Column(DB.DateTime)
+


blank line contains whitespace

hound · 2019-10-28T11:40:19Z

tmessage/db.py

-@MESSAGES_DB
-def store_messages(user, raw_msg):
-    """Store a message sent by the indicated user in the database"""
+    if new == True:


comparison to True should be 'if cond is True:' or 'if cond:'
too many blank lines (2)

hound · 2019-10-28T11:40:19Z

tmessage/db.py

-    sender = CharField()
-    message = CharField()
-    timestamp = DateTimeField()
+    class Message(Model):


too many blank lines (2)

hound · 2019-10-28T11:41:18Z

tmessage/cli.py

 from simple_chalk import chalk
 import tmessage.auth as auth  # auth.py
-from tmessage.db import store_messages  # db.py
+from tmessage.db import database # db.py


at least two spaces before inline comment

hound · 2019-10-28T11:48:17Z

tmessage/db.py

-@MESSAGES_DB
-def store_messages(user, raw_msg):
-    """Store a message sent by the indicated user in the database"""
+    if new = True:


SyntaxError: invalid syntax
too many blank lines (2)

hound · 2019-10-28T11:48:17Z

tmessage/db.py

-MESSAGES_DB = SqliteDatabase('message_store.sqlite')
+def database(user, raw_msg, new):
+    """user for sender, raw_msg for message, new if the user is new"""
+    MESSAGES_DB = SqliteDatabase(f'{user}.db')# pylint: disable=invalid_name


at least two spaces before inline comment

hound · 2019-10-28T11:51:23Z

tmessage/db.py

-@MESSAGES_DB
-def store_messages(user, raw_msg):
-    """Store a message sent by the indicated user in the database"""
+    if new == True: # pylint: disable=singleton-comparison


at least two spaces before inline comment
comparison to True should be 'if cond is True:' or 'if cond:'
too many blank lines (2)

HashirGJ8842 added 3 commits October 27, 2019 15:58

Update db.py

ecf0b84

Update db.py

2b4fc33

In this edit, we can now create new databases for the users who have recently registered, and the messages sent by the users will be stored in their respective databases. I have used SQLAlchemy instead of peewee.

'new' variable to create databases for new users

c01ddfe

Just added a variable 'new' in line 65 and line 78. And a new argument named 'new'.

hound bot reviewed Oct 27, 2019

View reviewed changes

Update db.py

65b1fc6

hound bot reviewed Oct 27, 2019

View reviewed changes

Update db.py

7f2e80b

Haider8 reviewed Oct 27, 2019

View reviewed changes

HashirGJ8842 added 4 commits October 27, 2019 20:48

Update db.py

e486493

Update requirements.txt

909f3a5

Update db.py

68f1dd5

Update db.py

98e7b29

hound bot reviewed Oct 27, 2019

View reviewed changes

HashirGJ8842 added 2 commits October 27, 2019 22:01

Update cli.py

40528e1

Update db.py

33dc6e2

hound bot reviewed Oct 27, 2019

View reviewed changes

HashirGJ8842 added 3 commits October 27, 2019 22:15

Update cli.py

65a4a1e

Update requirements.txt

cf9cbed

Update db.py

0c9c00c

hound bot reviewed Oct 27, 2019

View reviewed changes

tmessage/db.py Outdated

timestamp = DateTimeField()

def add(self):

return 1+1

def __repr__(self):

Copy link

hound bot Oct 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected 1 blank line, found 0

HashirGJ8842 added 9 commits October 28, 2019 00:11

Update db.py

009cf89

Update requirements.txt

e67459b

Update requirements.txt

0166b7c

Update requirements.txt

7c468e9

Update .travis.yml

c39ab5c

Update .travis.yml

b901b95

Update .travis.yml

3e0abc6

Update .travis.yml

72b58f6

Update .travis.yml

92efb10

HashirGJ8842 added 7 commits October 28, 2019 00:46

Update .travis.yml

cc36051

Update .travis.yml

b884ce8

Update requirements.txt

6931784

Update requirements.txt

b7311b9

Update .travis.yml

ce5bea9

Update .travis.yml

5616731

Update db.py

2f55181

hound bot reviewed Oct 27, 2019

View reviewed changes

tmessage/db.py Outdated

def add(self):

""" To few methods"""

print(self.sender)

Copy link

hound bot Oct 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

HashirGJ8842 added 5 commits October 28, 2019 02:01

Update auth.py

4406ae4

Update .travis.yml

b1bc6a1

Update db.py

d622585

Update requirements.txt

0701dfb

Update db.py

366b3e1

hound bot reviewed Oct 27, 2019

View reviewed changes

HashirGJ8842 added 3 commits October 28, 2019 02:22

Update requirements.txt

8935f70

Update requirements.txt

14c401c

Update db.py

8393997

hound bot reviewed Oct 28, 2019

View reviewed changes

Update cli.py

badbe2a

hound bot reviewed Oct 28, 2019

View reviewed changes

Update db.py

e113d4e

hound bot reviewed Oct 28, 2019

View reviewed changes

Update db.py

4686635

hound bot reviewed Oct 28, 2019

View reviewed changes

HashirGJ8842 added 2 commits October 28, 2019 17:23

Update db.py

9b3692d

Update cli.py

30960f9

		@@ -1,28 +1,34 @@
		"""Handles the connection to the SQLite database as well as DB interaction"""
		pip install flask

		def new_database(user):
		APP.config['SQLALCHEMY_BINDS'][user] = f'sqlite:///{user}.db'

Conversation

HashirGJ8842 commented Oct 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pep8speaks commented Oct 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2019-10-29 07:48:29 UTC

Uh oh!

hound bot Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

Haider8 Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

HashirGJ8842 Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

Haider8 Oct 28, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 28, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 28, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 28, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 28, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 28, 2019

Choose a reason for hiding this comment

Uh oh!

hound bot Oct 28, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

HashirGJ8842 commented Oct 27, 2019 •

edited

Loading

pep8speaks commented Oct 27, 2019 •

edited

Loading