Skip to content

implemented encryption with static key#51

Open
csaranbalaji wants to merge 5 commits intoHaider8:masterfrom
csaranbalaji:encryption
Open

implemented encryption with static key#51
csaranbalaji wants to merge 5 commits intoHaider8:masterfrom
csaranbalaji:encryption

Conversation

@csaranbalaji
Copy link
Contributor

Partially resolves #18

  • Implemented encryption with a static key.
  • added TODO in get_encryption_key function.

@csaranbalaji
Copy link
Contributor Author

@Haider8 , I couldn't achieve encryption without a static key. Maybe someone else can pick it up.

@Haider8
Copy link
Owner

Haider8 commented Oct 16, 2019

@iamareebjamal Can you please take a look here

@iamareebjamal
Copy link

@Haider8 This is incomplete

@csaranbalaji
Copy link
Contributor Author

@iamareebjamal @Haider8 As mentioned in PR, It is incomplete because end to end encryption isn't achieved. But this would work with the static key which is provided in this PR. The thing which is yet to be done is the exchange of keys between the users which I have mentioned as "someone else can take it". So in this PR the messages are send and received in an encrypted way where the static key is shared among the users (ie) the members who have this key can view the message by using Fernet algorithm. Hopefully you can merge this PR to master or if you don't needed encryption with a static key, you can have it in a new branch called encryption so that someone else can work on it.

@pep8speaks
Copy link

pep8speaks commented Dec 14, 2019

Hello @csaranbalaji! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-14 15:23:20 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement encryption

4 participants