Skip to content

Skip processing unused controllers via mask#9

Open
someone2639 wants to merge 14 commits intoHackerN64:mainfrom
farisawan-2000:mask
Open

Skip processing unused controllers via mask#9
someone2639 wants to merge 14 commits intoHackerN64:mainfrom
farisawan-2000:mask

Conversation

@someone2639
Copy link
Copy Markdown

Comment thread include/PR/os_cont.h Outdated
Comment thread src/io/contreaddata.c
@someone2639 someone2639 added Console Testing Needed Behavior must be verified on console Extra Hardware Needed Needs hardware verification with e.g. nonstandard/multiple controllers, mempaks, etc. labels Feb 21, 2025
Comment thread src/io/pfsisplug.c
Comment thread src/io/contsetch.c
Comment thread src/io/contsetch.c
Comment thread src/io/contreaddata.c
Copy link
Copy Markdown

@Thar0 Thar0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides comment typo

Comment thread src/io/contreaddata.c Outdated
Copy link
Copy Markdown

@Thar0 Thar0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool feature

@someone2639
Copy link
Copy Markdown
Author

Requesting re-review since now gamecube controllers are involved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Console Testing Needed Behavior must be verified on console Extra Hardware Needed Needs hardware verification with e.g. nonstandard/multiple controllers, mempaks, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants