Skip to content

Conversation

@hjvuor
Copy link
Contributor

@hjvuor hjvuor commented Jan 8, 2026

Proposed Changes

  • Adds park and ride icons to Oulu and Turku
  • Includes minor tweaks to improve icon scaling based on zoom level

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in an issue in Azure Boards
  • Merge the pull request

@hjvuor hjvuor marked this pull request as draft January 8, 2026 13:57
@hjvuor hjvuor marked this pull request as ready for review January 8, 2026 13:59
Copy link
Member

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes:

  • Please set parkAndRideMinZoom=13 in config.default.js and parkAndRideMinZoom=14 in config.waltti.js. Other MinZoom values can be then removed.
  • There seems to be a badly implemented CityBikeNearYou specific way to change minzoom per view type. It would be good to show markers in all zoom levels in dedicated views: parks near you or park station view should keep on showing all stations even when zoomed to show whole service area. Please consider if this is a suitable time to implement a general (not citybike related) solution and hook it in within this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants