Conversation
When activity entries target multiple fleets (e.g. INGEST_CONFIG_CHANGED), the backend returns targets in Set iteration order which varies across JVM instances. The frontend displayed only targets[0], causing fleet names to appear to swap when requests hit different nodes or after restarts. Sort targets alphabetically on the frontend and show "and N other fleet(s)" for multi-target entries. Narrow useRecentActivity return type to match the useCollectorsConfig pattern for type-safe test mocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #25384
/nocl unreleased feature
INGEST_CONFIG_CHANGEDwhich targets all fleets) displayed onlytargets[0], whose position depends on JavaSetiteration order — non-deterministic across JVM instances/restartstoSorted()so the displayed fleet name is always deterministicuseRecentActivityreturn type to match theuseCollectorsConfigpatternTest plan
INGEST_CONFIG_CHANGEDentries show "and N other fleets" when multiple fleets existnpx jest --no-coverage src/components/collectors/overview/RecentActivity.test.tsxpasses (5 tests)