Add new error types to validate time range#25585
Open
maxiadlovskii wants to merge 10 commits intomasterfrom
Open
Add new error types to validate time range#25585maxiadlovskii wants to merge 10 commits intomasterfrom
maxiadlovskii wants to merge 10 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds new types for error responses, which we then use on FE to detect if the search result has a time range error. if it has we show error icon on timerange preset button.
In addition, we are fixing the issue when the loading state of the search button is blinking ( loading state -> no loader for a moment -> loading state). We are doing that by doing
dispatch(loading());beforedispatch(parseSearch(search, searchExecutors.parse)Motivation and Context
fix: #15957
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: