Skip to content

Add new error types to validate time range#25585

Open
maxiadlovskii wants to merge 10 commits intomasterfrom
fix/validate-if-keyword-time-range-on-results/issue-15957
Open

Add new error types to validate time range#25585
maxiadlovskii wants to merge 10 commits intomasterfrom
fix/validate-if-keyword-time-range-on-results/issue-15957

Conversation

@maxiadlovskii
Copy link
Copy Markdown
Contributor

@maxiadlovskii maxiadlovskii commented Apr 9, 2026

Description

This PR adds new types for error responses, which we then use on FE to detect if the search result has a time range error. if it has we show error icon on timerange preset button.

In addition, we are fixing the issue when the loading state of the search button is blinking ( loading state -> no loader for a moment -> loading state). We are doing that by doing dispatch(loading()); before dispatch(parseSearch(search, searchExecutors.parse)

Motivation and Context

fix: #15957

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@maxiadlovskii maxiadlovskii added the e2e-tests Run PR build with e2e tests. label Apr 9, 2026
@maxiadlovskii maxiadlovskii marked this pull request as ready for review April 10, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e-tests Run PR build with e2e tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search page does not validate if keyword time range exceeds query limit when opening saved search.

1 participant