Add Confirmation Dialog for Manual Updates on Metered/Roaming Networks#105
Open
haok1402 wants to merge 1 commit into
Open
Add Confirmation Dialog for Manual Updates on Metered/Roaming Networks#105haok1402 wants to merge 1 commit into
haok1402 wants to merge 1 commit into
Conversation
thestinger
force-pushed
the
15-qpr2
branch
14 times, most recently
from
cddb120 to
0e93954
Compare
haok1402
force-pushed
the
fix-mismatched-network
branch
from
9200e08 to
7919723
Compare
haok1402
force-pushed
the
fix-mismatched-network
branch
from
7919723 to
2f78d23
Compare
|
Hi @haok1402, is it still a draft or ready for review? |
|
Thanks @de0u! Feel free to ping me when this PR is ready for review :) |
If the current network is metered or roaming, and settings would preclude an automatic fetch, require the user to confirm before starting a manual update.
haok1402
force-pushed
the
fix-mismatched-network
branch
from
2f78d23 to
4c4452a
Compare
Contributor
Author
|
@RankoR I've performed the rebase to the latest upstream |
Contributor
Author
|
@RankoR I've built on the |
RankoR
approved these changes
Jun 14, 2026
Member
|
I don't think this should cause any issues on the |
|
I will check with @haok1402 about scheduling testing. Thanks! |
Contributor
Author
|
@inthewaves Yes! I'll take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR improves the System Updater by notifying users when they attempt a manual update check while connected to a network that does not match the network properties required for automatic updates (e.g., metered or roaming). Previously, network restrictions were enforced only for background updates. Manual update checks bypassed these settings, which could result in unintended data charges.
With this change, the user will be prompted with an alert dialog if the current network does not match the configured properties. The update check will proceed only if the user explicitly confirms.
Changes:
Testing:
Tested with Pixel 6a on the
16-qpr2branch to ensure:Screenshot from the testing can be found below.
I am happy to revise and resubmit the code if any changes are desired.