[#52] feat(Vfs): support compressed VDF Union files#124
Merged
lmichaelis merged 5 commits intoGothicKit:mainfrom Mar 15, 2026
Merged
[#52] feat(Vfs): support compressed VDF Union files#124lmichaelis merged 5 commits intoGothicKit:mainfrom
lmichaelis merged 5 commits intoGothicKit:mainfrom
Conversation
lmichaelis
added
enhancement
Member
|
Thank you for this work! It looks good a cursory glance and I hope to find some time later this week to take a closer look :) The failing tests on Windows are likely not related to this PR btw |
lmichaelis
requested changes
Mar 7, 2026
Member
lmichaelis
left a comment
lmichaelis
left a comment
There was a problem hiding this comment.
Great work! I only a have a few minor requests.
Contributor
Author
|
Thanks for the review! I made the changes you requested. |
Member
|
Thank you so much! It's merged :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading and saving zipped VDF files (Union ZippedStream format).
The support is optional (disabled by default) and can be turned on with
ZK_ENABLE_ZIPPED_VDFcmake option.See the issue #52 for more details.
What's been done to verify that it works:
Union.vdffile mentioned in the issue above can be successfully loaded by ZenKit.basic_zipped.vdffile that was saved as zipped by the aforementioned VDFSTool, and the second which tests the round-trip: saves vdf as zipped, and then reads it.