Make filter method take a string, eg for use with tags.contains:foo#117
Open
smemsh wants to merge 1 commit intoGothenburgBitFactory:developfrom
Open
Make filter method take a string, eg for use with tags.contains:foo#117smemsh wants to merge 1 commit intoGothenburgBitFactory:developfrom
tags.contains:foo#117smemsh wants to merge 1 commit intoGothenburgBitFactory:developfrom
Conversation
smemsh
force-pushed
the
handle-string-tags-arg
branch
from
78a8b97 to
10c7837
Compare
Author
|
@tbabej since you did a release, should I conclude this patch will not be merged? |
the example in readme says this example works, but actually it splits the argument by ',' unconditionally, expecting a list. so a string will be made into a "s,t,r,i,n,g". so we should handle getting passed either a single string and pass it through unchanged, or a list and join them actually if a list, we'd want to dedupe so we use a set which is the native type of the library for tags anyways
smemsh
force-pushed
the
handle-string-tags-arg
branch
from
10c7837 to
78aa1b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example in README says this works:
but actually in
deserialize_tags(), which ends up getting this, there is expectation for a list parameter, so not sure how the example from README ever worked (!)This patch changes
.filter()method to support a string argument also, which in that case is passed through unchanged. This makes the README example work again.Fixes #116