Skip to content

clone global stylesheet elements into root for shadowdom support #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
e111077 merged 2 commits into from
Nov 28, 2018
Merged

clone global stylesheet elements into root for shadowdom support #223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
892aba1
clone stylesheets into root
Nov 28, 2018
84116c5
move style localization to function and two loops and only once
Nov 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions google-chart.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
-->
<dom-module id="google-chart">
<template>
<div id="styles"></div>
<style include="google-chart-styles"></style>
<google-chart-loader id="loader" type="[[type]]"></google-chart-loader>
<div id="chartdiv"></div>
Expand Down Expand Up @@ -310,6 +311,12 @@
_typeChanged: function() {
this.$.loader.create(this.type, this.$.chartdiv)
.then(function(chart) {

// only add link stylesheet elements if there are none already
if (!this.$.styles.children.length) {
this._localizeGlobalStylesheets();
}

var loader = this.$.loader;
Object.keys(this.events.concat(['select', 'ready'])
.reduce(function(set, eventName) {
Expand Down Expand Up @@ -469,6 +476,33 @@
.then(function(dataView) {
this._dataView = dataView;
}.bind(this));
},

/**
* Queries global document head for google charts link#load-css-* and clones
* them into the local root's div#styles element for shadow dom support.
*/
_localizeGlobalStylesheets: function() {
Copy link
Member

@wesalvaro wesalvaro Dec 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my version in #204 handles some edge cases a little better.
https://github.com/GoogleWebComponents/google-chart/pull/204/files#diff-d0b4f475ae2630d8efc01169d1a41af6R80

Copy link
Contributor Author

@e111077 e111077 Dec 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged this on behalf of an internal request from a blocked user. I'd 100% be willing to review your import CL over this implementation.

// get all gchart stylesheets
var stylesheets = Polymer.dom(document.head)
.querySelectorAll('link[rel="stylesheet"][type="text/css"]');

var stylesheetsArray = Array.from(stylesheets);

for (var i = 0; i < stylesheetsArray.length; i++) {
Copy link

@aomarks aomarks Nov 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.forEach should be safe for both Array and NodeList

Copy link

@aomarks aomarks Nov 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh not for IE11 though maybe?

var sheetLinkEl = stylesheetsArray[i];
var isGchartStylesheet = sheetLinkEl.id.indexOf('load-css-') == 0;

if (isGchartStylesheet) {
// clone necessary stylesheet attributes
var clonedLinkEl = document.createElement('link');
clonedLinkEl.setAttribute('rel', 'stylesheet');
clonedLinkEl.setAttribute('type', 'text/css');
clonedLinkEl.setAttribute('href', sheetLinkEl.getAttribute('href'));

Polymer.dom(this.$.styles).appendChild(clonedLinkEl);
}
}
}
});
})();
Expand Down