Fix TypeError when calling decorated methods with positional arguments#93
Merged
Conversation
The _cache decorator's wrapper was defined as cache(self, **kwargs), which failed with a TypeError when decorated methods (like output()) were called with positional arguments. We now use inspect.signature to bind the arguments, allowing both positional and keyword arguments to be handled correctly while preserving cache key generation. Also added a regression test to test_cache.py and bumped the version to 1.8.8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Calling decorated methods (such as
output()) with positional arguments resulted in aTypeError(e.g.,TypeError: TerraformTest._cache.<locals>.cache() takes 1 positional argument but 2 were given). This occurred because the_cachedecorator's wrapper was defined to only acceptselfand**kwargs.This PR fixes the issue by updating the decorator to:
*argsand**kwargs.inspect.signatureto dynamically bind the arguments to the target function's signature. This ensures positional arguments are correctly mapped to their parameter names.selfargument from the bound arguments before hashing to prevent the object's memory address from invalidating the cache.Tests
test_output_positional_argtotest/test_cache.pyto verify that callingoutput()with positional arguments works correctly when caching is enabled.Related Issues