Fix TestNetworkHealthCheck flakiness by waiting for logging and monitoring endpoints to block#2372
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
waitForNetworkBlockinintegration_test/ops_agent_test/main_test.goto explicitly verify thatlogging.googleapis.comandmonitoring.googleapis.comare blocked (in addition totelemetry,dl, andpackages) before proceeding with the network health check assertions.Why
When the
DenyEgressTrafficTag(test-ops-agent-deny-egress-traffic-tag) is attached to a test VM, GCE firewall rule enforcement propagates across different destination IP routing tables with eventual consistency.Previously,
waitForNetworkBlockonly checked whethertelemetry.googleapis.com,dl.google.com, andpackages.cloud.google.comwere blocked. Once those three endpoints timed out, the test runner immediately executed the agent's health checks. However, connections tologging.googleapis.comandmonitoring.googleapis.comwould frequently remain open for a few seconds longer, causingTestNetworkHealthCheckto fail when the API checks unexpectedly returnedPASSinstead ofFAIL.Related issue
b/532086232
How has this been tested?
Checklist: