Add instance_name metric label to stackdriver monitoring labels#66
Open
cristynkells wants to merge 2 commits into
Open
Add instance_name metric label to stackdriver monitoring labels#66cristynkells wants to merge 2 commits into
cristynkells wants to merge 2 commits into
Conversation
Enhance Cloud Monitoring metrics emitted by the MLLP adapter by adding a new `instance_name` label derived from GCE metadata. This change preserves backward compatibility by retaining the existing `instance` label (instance ID) and introduces an additional human-readable identifier for improved observability in Metrics Explorer and dashboards. No existing labels are modified or removed. Changes: - Add metadata.InstanceName() retrieval during metric exporter startup - Introduce optional `instance_name` label to DefaultMonitoringLabels - Fail-safe behavior: absence of instance name does not impact metric export Impact: - Improves filtering and grouping in Cloud Monitoring - Enables easier debugging and per-VM identification - Fully backward compatible with existing dashboards and alerting rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance Cloud Monitoring metrics emitted by the MLLP adapter by adding a new
instance_namelabel derived from GCE metadata.This change preserves backward compatibility by retaining the existing
instancelabel (instance ID) and introduces an additional human-readableidentifier for improved observability in Metrics Explorer and dashboards.
No existing labels are modified or removed.
Changes:
instance_namelabel to DefaultMonitoringLabelsImpact: