Skip to content

fix: use Go module proxy instead of GitHub API to resolve client version #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taeold wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use Go module proxy instead of GitHub API to resolve client version #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/actions/client/resolve-latest/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,17 @@ outputs:
runs:
using: "composite"
steps:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: 1.x
- name: Resolve latest conformance test client version
id: resolve-latest-client
run: |
echo "::set-output name=version::$(curl --silent "https://api.github.com/repos/GoogleCloudPlatform/functions-framework-conformance/releases/latest" | jq -r '.tag_name')"
VERSION=$(go list -m -json github.com/GoogleCloudPlatform/functions-framework-conformance@latest | jq -r '.Version')
if [ "$VERSION" = "null" ] || [ -z "$VERSION" ]; then
echo "Failed to resolve latest version"
exit 1
fi
echo "version=$VERSION" >> $GITHUB_OUTPUT
shell: bash
2 changes: 1 addition & 1 deletion .github/workflows/buildpack-integration-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ jobs:
run: echo CLIENT_VERSION=${{ steps.conformance-client-latest.outputs.version }} >> $GITHUB_ENV
- name: Set cache key for client version
id: set-cached-client-version
run: echo "::set-output name=key::conformance-client-${{ env.CLIENT_VERSION }}"
run: echo "key=conformance-client-${{ env.CLIENT_VERSION }}" >> $GITHUB_OUTPUT

# INSTALL CONFORMANCE CLIENT
- name: Check for cached conformance test client
Expand Down
Loading