Support log level setting per plugin#268
Support log level setting per plugin#268okkez wants to merge 5 commits intoGoogleCloudPlatform:masterfrom
Conversation
We must use `$log` for logging while configuring.
|
@qingling128 what does it take to resolve this PR? |
|
Looks like it needs rebasing. I tried the Github UI tool, but there is still a test failure. @okkez - Mind rebasing this off the latest master if it's still needed? |
|
Rubocop causes CI failure. I've fixed it. |
| @vm_id ||= ec2_metadata['instanceId'] if @platform == Platform::EC2 | ||
| rescue StandardError => e | ||
| @log.error 'Failed to obtain vm_id: ', error: e | ||
| log.error 'Failed to obtain vm_id: ', error: e |
There was a problem hiding this comment.
Curious: How did we decide which cases are log, and which cases are $log?
There was a problem hiding this comment.
It's hidden in the extra part of the commit message on 63387b5. Frankly, I'd prefer it as a code comment in configure.
igorpeshansky
left a comment
igorpeshansky
left a comment
There was a problem hiding this comment.
@okkez, can you please expand on what exactly this PR accomplishes? Frankly, I don't see how the commits relate to the PR title. Is there a real-world problem this solves? Is there a best practices document we can look at to justify these changes?
| @vm_id ||= ec2_metadata['instanceId'] if @platform == Platform::EC2 | ||
| rescue StandardError => e | ||
| @log.error 'Failed to obtain vm_id: ', error: e | ||
| log.error 'Failed to obtain vm_id: ', error: e |
There was a problem hiding this comment.
It's hidden in the extra part of the commit message on 63387b5. Frankly, I'd prefer it as a code comment in configure.
|
AFAIK, there is no document about |
5 participants
No description provided.