[Enhancement] simplify python rules#64
Open
iwilltry42 wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
Open
[Enhancement] simplify python rules#64iwilltry42 wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
iwilltry42 wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
Conversation
igorpeshansky
suggested changes
Oct 17, 2019
This reverts commit 71cc0fa.
igorpeshansky
suggested changes
Oct 23, 2019
Contributor
igorpeshansky
left a comment
igorpeshansky
left a comment
There was a problem hiding this comment.
Let's make sure this gets tested...
Author
|
Hi @igorpeshansky , is there anything left to do for me? :) |
|
Hi! Any chance this fix is ready to merge soon? |
Author
|
Hi @igorpeshansky , I added the requested tests but the PR is still showing |
Author
|
Hi @igorpeshansky is there anything left to do here? |
|
@igorpeshansky is there anything keeping you from merging this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Simplify python rules to only have 2 states and a single regex for matching lines between the start (
Traceback ...) and End (<Error>...) of a Traceback.The new regex matches any line that starts with one or more tabs/spaces, followed by at least one non-whitespace symbol, followed by whatever else.
Why
This is the second proposed option here: #62 (comment)
Fix #62
FYI @jkschulz & @igorpeshansky