Enable deterministic Go Protobuf marshaling (encoding)#889
Enable deterministic Go Protobuf marshaling (encoding)#889stapelberg wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
While developing Go Protobuf, we found this line to be responsible for a test failure when enabling fully lazy extensions (Google-internal bug reference: b/328746084). Your test seems to compare Protobuf-encoded data. As explained on go/go-proto-stability, you should not rely on the Protobuf wire encoding being stable across different versions of your program. go/go-proto-stability lists a couple of strategies you could pursue for a more reliable test, but for now, to unblock our optimization, enabling deterministic marshaling side-steps many vectors for change.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stapelberg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @stapelberg. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
cc: @shuoyang2016 |
While developing Go Protobuf, we found this line to be responsible for a test failure when enabling fully lazy extensions (Google-internal bug reference: b/328746084).
Your test seems to compare Protobuf-encoded data. As explained on go/go-proto-stability, you should not rely on the Protobuf wire encoding being stable across different versions of your program.
go/go-proto-stability lists a couple of strategies you could pursue for a more reliable test, but for now, to unblock our optimization, enabling deterministic marshaling side-steps many vectors for change.