Fallback to default app storage on Android when custom storage lacks permissions#22
Open
GooGuJiang wants to merge 1 commit intov2from
Open
Fallback to default app storage on Android when custom storage lacks permissions#22GooGuJiang wants to merge 1 commit intov2from
GooGuJiang wants to merge 1 commit intov2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
usingaliasRuntimeInfo = osu.Framework.RuntimeInfoand a new fallback flow in the realm startup catch block which attemptstryFallbackToDefaultStoragebefore performing other recovery logic and backups.tryFallbackToDefaultStorage(Exception)to detect Android runtime, confirm usage ofIO.OsuStoragewith a custom path, inspect the root exception message for permission-related failures, log the event, reset the custom storage path, and return true to retry opening the realm.isStoragePermissionFailure(string)to centralize detection of permission/read-only errors in exception messages.Testing
dotnet testand observed no regressions in automated tests.Codex Task