Skip to content
This repository was archived by the owner on Jul 30, 2019. It is now read-only.

Scripts are almost working on Ubuntu#3

Open
ehsavoie wants to merge 1 commit into
Godin:masterfrom
ehsavoie:master
Open

Scripts are almost working on Ubuntu#3
ehsavoie wants to merge 1 commit into
Godin:masterfrom
ehsavoie:master

Conversation

@ehsavoie

Copy link
Copy Markdown

Updating scripts to enable the download of the sonar zip distribution on sonarqube.

@Godin

Godin commented Jul 25, 2013

Copy link
Copy Markdown
Owner

@ehsavoie What is the purpose of this change?

Comment thread build.sh

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bash is required? Script supposed to work in any shell.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

@Godin

Godin commented Sep 24, 2013

Copy link
Copy Markdown
Owner

In fact my original question can be rephrased as: why someone would like to build package instead of downloading from http://sonar-pkg.sourceforge.net/ ? And as long as packages are built by one person - there is no need in changing layout of directories ;) Explanation of layout: I also maintain Gentoo ebuild for Sonar and due to this distribution is automatically downloaded into "/usr/distfiles" prior to execution of those scripts. However indeed - this change can be applied without breaking my layout/workflow.

@ehsavoie

Copy link
Copy Markdown
Author

Well because sometimes you're on vacation ;o) and neither Simon nor Fabrice could release the new version.

Because it's an opensource project and maybe people would want to package their plugins in their distribution, or don't want to add another external repo, or whatever ....

Comment thread deb/build.sh

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Execution will be continued even if directories can't be removed/created, whereas fail-fast should be preferred to avoid wrong build.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep but it will fail on first execution because those repositories don't exist in the first place.

@Godin

Godin commented Sep 24, 2013

Copy link
Copy Markdown
Owner

I didn't said that this change can't be accepted in general ;) I'd be happy to apply it, when issues described in my comments to code will be solved.

@timp21337

Copy link
Copy Markdown

I used this script, because I was not sure that the site http://sonar-pkg.sourceforge.net/ was part of the project!
I now realise it is, but by that time I had downloaded and built.

@phermsdorf

Copy link
Copy Markdown

Oviously it would be a good idea to be able to build the packages locally since the binary packages haven't been updated for more than 4 months now ...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants