Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a user profile and github token saving after logging in #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Added a user profile and github token saving after logging in #490
Changes from all commits
81db477f0620bd4dd08d04814dd4210bf0acd0e174b4c8307e8b6fa2File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid storing GitHub PATs as plaintext in user records.
This persists a long-lived credential directly in clear text. Encrypt it at rest (or use a secrets vault pattern) and avoid exposing it by default in queries.
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reject whitespace-only token input.
At Line 44, a string like
" "passes validation and gets stored as a token. Trim first and validate the trimmed value.Suggested patch
📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify update success and avoid leaking raw backend errors.
At Line 48-53, this always returns success when no document is updated, and exposes
err.messageto clients. Return a safe generic 500 and handle null-update/duplicate-key cases explicitly.Suggested patch
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unused
Githubimport to clear lint failure.Githubis imported but never used, matching the ESLint error.Suggested fix
📝 Committable suggestion
🧰 Tools
🪛 ESLint
[error] 5-5: 'Github' is defined but never used.
(
@typescript-eslint/no-unused-vars)🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle non-success API responses explicitly.
If the request resolves but
successis false, the UI shows no error and does nothing. Add anelsebranch to set a message.Suggested patch
if (response.data.success) { updateToken(token); navigate("/"); + } else { + setMessage(response.data.message ?? "Failed to save token."); }📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unify user identifier contract (
idvs_id) across backend/frontend.UserDatarequires_id, but current auth payload usesid. This mismatch is brittle and can break state handling unless every caller remaps fields.Suggested patch (frontend contract-side)
export interface UserData { - _id: string; + id: string; + _id?: string; username: string; email: string; token?: string; }🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.