WIP: Synchronisation rebuild#20
Open
michael-gratton wants to merge 22 commits into
Open
Conversation
Assume a default id setting exists (this should be set via a corresponding `NATION_BUILDER_DEFAULT_EVENT_CAMPAIGN_ID` setting) and set that on new events if needed.
Handle merging base on NB persion data using both merging and overwriting strategies. Merging allows two records that were not previously associated to be updated from both. Overwriting allows subsequent updates to be applied, even if destructive.
The old `NationBuilderMemberSyncPushSerializer` name is redundant with the `IdentityNationBuilder` namespace and is not specific to syncs or pushes. It's also rather long. So call it `PersonSerialzer` instead.
XXX This is not yet complete or functional.
michael-gratton
force-pushed
the
sync_updates
branch
from
9f78920 to
0ad7927
Compare
michael-gratton
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A complete rebuild of the Id/NB synchronisation.