allow returning of associate array instead of object#3
Open
jamie-beck wants to merge 4 commits intoGetResponse:masterfrom
Open
allow returning of associate array instead of object#3jamie-beck wants to merge 4 commits intoGetResponse:masterfrom
jamie-beck wants to merge 4 commits intoGetResponse:masterfrom
Conversation
things like $response->{'0'} seem clumsy compared to $response[0]
in my opinion arrays are easier to iterate over too
added getCampaignContacts() enhanced getCampaigns() to allow for params moved all GET params prep to call() normalized GET params usage in all methods
enhanced getCampaign() to accept params
shame on me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things like $response->{'0'} seem clumsy compared to $response[0]
In my opinion arrays are easier to iterate over too.
Its more efficient to handle it by json_decode() directly then on the outside of the class.