fix(mcp): handle string-typed numeric params in intArg#123
Open
todie wants to merge 1 commit intoGentleman-Programming:mainfrom
Open
fix(mcp): handle string-typed numeric params in intArg#123todie wants to merge 1 commit intoGentleman-Programming:mainfrom
todie wants to merge 1 commit intoGentleman-Programming:mainfrom
Conversation
The intArg helper only type-asserted to float64, which silently failed when the MCP transport sent numeric params as strings. This caused "id is required" errors on mem_update, mem_delete, and mem_timeline. Add strconv.Atoi fallback via type switch so both float64 and string representations are handled correctly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
todie
force-pushed
the
fix/intarg-string-parsing
branch
from
57ffc60 to
ea53bdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
intArg()only type-asserted tofloat64, silently returning0when the MCP transport sent numeric params as strings"id is required"errors onmem_update,mem_delete, andmem_timelinestrconv.Atoifallback via type switch so bothfloat64andstringrepresentations are handledTest plan
TestHandleUpdateAcceptsAllOptionalFieldspassesmem_update,mem_delete,mem_timelinework whenidarrives as string🤖 Generated with Claude Code