Skip to content

Conversation

@tars919
Copy link
Contributor

@tars919 tars919 commented Jan 27, 2026

Description

Added GET /requests endpoint to retrieve all requests

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • [x ] New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (code improvement without changing functionality)
  • Documentation update
  • Configuration/infrastructure change
  • Performance improvement
  • [x ] Test coverage improvement

Related Issue(s)

Closes #69

What Changed?

  • Added GetAllRequests method to RequestsRepository
  • Added GetAllRequests handler
  • Added GetAllRequests to the interface
  • Registered /requests GET route
  • Updated test mocks

Testing & Validation

How this was tested

  1. All tests pass

Screenshots/Recordings

Unfinished Work & Known Issues

  • None, this PR is complete and production-ready
  • The following items are intentionally deferred:



Notes & Nuances



Pre-Merge Checklist

Code Quality

  • [x ] Code follows the project's style guidelines and conventions
  • [x ] Self-review completed (I've reviewed my own code for obvious issues)
  • [x ] No debugging code, console logs, or commented-out code left behind
  • [x ] No merge conflicts with the base branch
  • [x ] Meaningful commit messages that explain the "why"

Testing & CI

  • [x ] All CI checks are passing
  • [x ] All new and existing tests pass locally
  • [x ] Test coverage hasn't decreased (or decrease is justified)
  • [x ] Linting passes without errors

Documentation

  • [x ] Code is self-documenting or includes helpful comments for complex logic
  • [x ] API documentation updated (if backend endpoints changed)
  • [x ] Type definitions are accurate and up-to-date

Reviewer Notes

  • Areas needing extra attention: ...
  • Questions for reviewers: ...

@danctila danctila self-requested a review January 31, 2026 03:10
Copy link
Contributor

@danctila danctila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall fire first pass at the UI and endpoints - looking very clean and the structure is solid overall, a few things to fix are below.

also make sure to fill out the PR description since its helpful to have more context on what was implemented / intentionally pushed off, any design decisions, etc. just a few bullet points and a screen recording of the flow workout would go a long way 🙏 (also these are good to look back on bc you can explicitly see where you contributed in each PR on your github)

Must fixes / blocking:

  • API endpoint mismatch b/t /request and /requests
  • Fix 500 error in POST - see the completed_at property in the INSERT / GET statement in /repository/requests.go

Should fix:

  • Remove mock data once API is working
  • Setup proper query invalidation pattern (see the suggestion)
  • Add error state handling in the UI
  • Fix the long type annotation in the map function

Nice to have:

  • Add TODO comment for hardcoded hotel ID / remove hardcoded data altogether

- Changed backend route from /request to /requests for consistency
- Removed completed_at from GetAllRequests SELECT statement
- Removed mock data from frontend
- Added query invalidation pattern in useCreateRequest hook
- Added error state with retry button in UI
- Fixed type annotation in map function
- Added TODO comment for hardcoded values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: manual request creation

2 participants