Merge GetNative refactor series (#61-#65)#67
Merged
Conversation
BugzId:65
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge the GetNative refactor series into main:
scoped_refptr-basedGetNative*scoped_refptr-basedGetNative*scoped_refptr-basedGetNative*scoped_refptr-basedGetNative*Fixes #61
Fixes #62
Fixes #63
Fixes #64
Fixes #65
Change Area (required)
WebRtcNet.Api/ managed-only behavior)Required Evidence (for behavioral/API changes)
N/A - no external WebRTC or Media Capture behavior change.
Test Evidence (required)
Tests added/updated
Commands run + results
dotnet test WebRtcNet.Api.UnitTests\WebRtcNet.Api.UnitTests.csproj— passed (110 tests)msbuild WebRtcInterop\WebRtcInterop.Framework.vcxproj -p:Configuration=Debug -p:Platform=x64— succeededmsbuild WebRtcInterop.UnitTests\WebRtcInterop.UnitTests.vcxproj -p:Configuration=Debug -p:Platform=x64— succeededWebRtcInterop.UnitTests\bin\x64\Debug\v4.8\WebRtcInterop.UnitTests.exe— passed (58 tests)Change-area test gate confirmation
If environment unavailable (required when checked above)
Documentation
Spec/Crosswalk Review (required for W3C-aligned behavior changes)
docs\\standards\\crosswalk\\webrtcnet-api-to-spec.mddocs\\standards\\specs\\index\\spec-map.md.\\scripts\\update-spec-docs.ps1) when needed