Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,13 @@ Use the `/findplayer` command and enter the player's name. There is also a dropd
![Usage](https://raw.githubusercontent.com/GalvinPython/minecraft-playerfinder/main/.github/assets/javaw_QXmxvWN79i.png)

# Compatible Versions
| Mod Version | Game Version(s) | Mod Version Title |
|-------------|-----------------|-------------------|
| 1.0.1 | 1.21 - 1.21.1 | 1.0.1+1.21 |
| 1.0.0 | 1.21 - 1.21.1 | 1.0.0+1.21 |
[![Supported versions](https://modrinth-shields.imgalvin.me/badge/playerfinder)](https://modrinth.com/mod/playerfinder)

AutoTorcher is available for Minecraft versions 1.20 and above!
Copy link

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line refers to "AutoTorcher" but this is the "PlayerFinder" mod. This appears to be copied from another project and should be corrected to reference the correct mod name.

Suggested change
AutoTorcher is available for Minecraft versions 1.20 and above!
Player Finder is available for Minecraft versions 1.20 and above!

Copilot uses AI. Check for mistakes.

Due to the frequency of Minecraft updates now, each Minecraft version has its own .jar file from 1.21.9 and above. This is mainly to prevent crashes from each drop.

Please also keep your loader and Fabric API up to date to ensure the best compatibility!

# Important Note
This mod is a **server-side** mod! You are **not** required to install this mod on the client-side, unless you are using the "Open to LAN" feature to create a server on your world.
Expand All @@ -26,6 +29,18 @@ Also: This mod requires the **Fabric API** and Fabric Loader **0.16.0 or higher
PS: *You cannot use this mod on servers that don't use this mod. The commands are created server-side*

# Changelog
## 1.0.4 (1.21.11)
* For 1.21.11 compatibility
* Updated dependencies

## 1.0.3 (1.21.10)
* For 1.21.10 compatibility
* Updated dependencies

## 1.0.2 (1.21.9)
* For 1.21.9 compatibility
* Updated dependencies (this is really important!)

## 1.0.1
* Added colours to the co-ordinates depending on the dimension
* Updated dimensions to remove "the" in the name
Expand Down
13 changes: 6 additions & 7 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,19 +1,18 @@
# Done to increase the memory available to gradle.
# Done to increase the memory available to Gradle.
org.gradle.jvmargs=-Xmx1G
org.gradle.parallel=true

# Fabric Properties
# check these on https://fabricmc.net/develop
minecraft_version=1.21
yarn_mappings=1.21+build.9
loader_version=0.16.0
minecraft_version=1.21.11
Copy link

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minecraft_version is set to "1.21.11" but the PR title indicates this is a release for version "1.21.10". This version mismatch needs to be corrected to ensure consistency across the project. It should likely be "1.21.10".

Copilot uses AI. Check for mistakes.
yarn_mappings=1.21.11+build.3
Copy link

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yarn_mappings version is set to "1.21.11+build.3" but the PR title indicates this is for Minecraft version "1.21.10". The yarn mappings version should match the Minecraft version and be "1.21.10+build.X" instead.

Suggested change
yarn_mappings=1.21.11+build.3
yarn_mappings=1.21.10+build.3

Copilot uses AI. Check for mistakes.
loader_version=0.18.4
loom_version=1.14-SNAPSHOT


# Mod Properties
mod_version=1.0.1+1.21
mod_version=1.0.4+1.21.11
Copy link

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mod_version includes "1.21.11" but the PR title indicates this is a release for version "1.21.10". The mod version should be "1.0.4+1.21.10" to maintain consistency with the Minecraft version being released.

Suggested change
mod_version=1.0.4+1.21.11
mod_version=1.0.4+1.21.10

Copilot uses AI. Check for mistakes.
maven_group=me.imgalvin.playerfinder
archives_base_name=player-finder

# Dependencies
fabric_version=0.102.0+1.21
fabric_version=0.140.2+1.21.11
Copy link

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fabric_version includes "1.21.11" but the PR title indicates this is a release for Minecraft version "1.21.10". The fabric version should be updated to match the correct Minecraft version (e.g., "0.140.2+1.21.10").

Suggested change
fabric_version=0.140.2+1.21.11
fabric_version=0.140.2+1.21.10

Copilot uses AI. Check for mistakes.
4 changes: 2 additions & 2 deletions src/main/java/me/imgalvin/playerfinder/PlayerFinder.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ public void onInitialize() {

BlockPos targetBlockPos = targetPlayer.getBlockPos();
BlockPos sourceBlockPos = sourcePlayer.getBlockPos();
RegistryKey<World> playerDimension = targetPlayer.getWorld().getRegistryKey();
RegistryKey<World> sourceDimension = sourcePlayer.getWorld().getRegistryKey();
RegistryKey<World> playerDimension = targetPlayer.getEntityWorld().getRegistryKey();
RegistryKey<World> sourceDimension = sourcePlayer.getEntityWorld().getRegistryKey();

boolean isSameDimension = sourceDimension == playerDimension;

Expand Down
6 changes: 3 additions & 3 deletions src/main/resources/fabric.mod.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
]
},
"depends": {
"fabricloader": ">=0.16.0",
"minecraft": "~1.21",
"fabricloader": ">=0.17.3",
"minecraft": "1.21.11",
Copy link

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Minecraft version is specified as "1.21.11" but the PR title indicates this is a release for version "1.21.10". There's a version mismatch that needs to be corrected. This should likely be "1.21.10" to match the release version in the PR title.

Suggested change
"minecraft": "1.21.11",
"minecraft": "1.21.10",

Copilot uses AI. Check for mistakes.
"java": ">=21",
"fabric-api": "*"
"fabric-api": ">=0.139.5"
}
}