Skip to content

fix: 1.21.9 player api changes #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GalvinPython merged 1 commit into from
Dec 30, 2025
Merged

fix: 1.21.9 player api changes #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,13 @@ Use the `/findplayer` command and enter the player's name. There is also a dropd
![Usage](https://raw.githubusercontent.com/GalvinPython/minecraft-playerfinder/main/.github/assets/javaw_QXmxvWN79i.png)

# Compatible Versions
| Mod Version | Game Version(s) | Mod Version Title |
|-------------|-----------------|-------------------|
| 1.0.1 | 1.21 - 1.21.1 | 1.0.1+1.21 |
| 1.0.0 | 1.21 - 1.21.1 | 1.0.0+1.21 |
[![Supported versions](https://modrinth-shields.imgalvin.me/badge/playerfinder)](https://modrinth.com/mod/playerfinder)

AutoTorcher is available for Minecraft versions 1.20 and above!
Copy link

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation mentions "AutoTorcher" instead of the correct mod name "PlayerFinder". This appears to be copied from another project.

Suggested change
AutoTorcher is available for Minecraft versions 1.20 and above!
PlayerFinder is available for Minecraft versions 1.20 and above!

Copilot uses AI. Check for mistakes.

Due to the frequency of Minecraft updates now, each Minecraft version has its own .jar file from 1.21.9 and above. This is mainly to prevent crashes from each drop.

Please also keep your loader and Fabric API up to date to ensure the best compatibility!

# Important Note
This mod is a **server-side** mod! You are **not** required to install this mod on the client-side, unless you are using the "Open to LAN" feature to create a server on your world.
Expand All @@ -26,6 +29,10 @@ Also: This mod requires the **Fabric API** and Fabric Loader **0.16.0 or higher
PS: *You cannot use this mod on servers that don't use this mod. The commands are created server-side*

# Changelog
## 1.0.2 (1.21.9)
* For 1.21.9 compatibility
* Updated dependencies (this is really important!)

## 1.0.1
* Added colours to the co-ordinates depending on the dimension
* Updated dimensions to remove "the" in the name
Expand Down
13 changes: 6 additions & 7 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,18 @@
# Done to increase the memory available to gradle.
# Done to increase the memory available to Gradle.
org.gradle.jvmargs=-Xmx1G
org.gradle.parallel=true

# Fabric Properties
# check these on https://fabricmc.net/develop
minecraft_version=1.21
yarn_mappings=1.21+build.9
loader_version=0.16.0
minecraft_version=1.21.9
yarn_mappings=1.21.9+build.1
loader_version=0.18.4
loom_version=1.14-SNAPSHOT


# Mod Properties
mod_version=1.0.1+1.21
mod_version=1.0.2+1.21.9
maven_group=me.imgalvin.playerfinder
archives_base_name=player-finder

# Dependencies
fabric_version=0.102.0+1.21
fabric_version=0.134.1+1.21.9
4 changes: 2 additions & 2 deletions src/main/java/me/imgalvin/playerfinder/PlayerFinder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ public void onInitialize() {

BlockPos targetBlockPos = targetPlayer.getBlockPos();
BlockPos sourceBlockPos = sourcePlayer.getBlockPos();
RegistryKey<World> playerDimension = targetPlayer.getWorld().getRegistryKey();
RegistryKey<World> sourceDimension = sourcePlayer.getWorld().getRegistryKey();
RegistryKey<World> playerDimension = targetPlayer.getEntityWorld().getRegistryKey();
RegistryKey<World> sourceDimension = sourcePlayer.getEntityWorld().getRegistryKey();

boolean isSameDimension = sourceDimension == playerDimension;

Expand Down
4 changes: 2 additions & 2 deletions src/main/resources/fabric.mod.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
},
"depends": {
"fabricloader": ">=0.16.0",
Copy link

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fabricloader version in gradle.properties was updated to 0.18.4, but the fabric.mod.json dependency still requires ">=0.16.0". For consistency and to ensure users have the latest loader features, consider updating the fabric.mod.json dependency to require ">=0.18.4" to match the development environment.

Suggested change
"fabricloader": ">=0.16.0",
"fabricloader": ">=0.18.4",

Copilot uses AI. Check for mistakes.
"minecraft": "~1.21",
"minecraft": "1.21.9",
Copy link

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Minecraft version constraint is now an exact version match ("1.21.9") rather than a version range. While the README mentions this is intentional to prevent crashes, this means the mod will not work with 1.21.10 or any future patch versions without an update. Consider using a tilde constraint like "~1.21.9" to allow compatible patch versions (e.g., 1.21.10, 1.21.11), or if breaking changes are expected in every patch version, consider documenting why this strict versioning is necessary.

Suggested change
"minecraft": "1.21.9",
"minecraft": "~1.21.9",

Copilot uses AI. Check for mistakes.
"java": ">=21",
"fabric-api": "*"
"fabric-api": ">=0.134.1"
}
}