Ignore this PR, folded branch#285
Closed
aidang3019 wants to merge 1 commit intographite-base/285from
Closed
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
aidang3019
force-pushed
the
aidan/bounds-check
branch
from
023180b to
49ef806
Compare
AnikethCheluva
approved these changes
Mar 13, 2026
SimarKareer
reviewed
Mar 13, 2026
| ), | ||
| ) | ||
|
|
||
| # Propagate norm stats to all zarrdatasets out of bounds check in getitem |
Collaborator
There was a problem hiding this comment.
Is there a reason we can't just directly set dataset.norm_stats = data_schematic.norm_stats. I wish we didn't have to add norm stats as an attribute after creating the dataset, but I'm not sure if there's a clean pattern to avoid this
RyanPCo
force-pushed
the
aniketh/bad-idx-fallback
branch
from
525dd6d to
a099aad
Compare
RyanPCo
force-pushed
the
aidan/bounds-check
branch
from
49ef806 to
b54c305
Compare
RyanPCo
force-pushed
the
aidan/bounds-check
branch
from
b54c305 to
0b6765d
Compare
RyanPCo
force-pushed
the
aniketh/bad-idx-fallback
branch
from
a099aad to
38d6b12
Compare
AnikethCheluva
force-pushed
the
aniketh/bad-idx-fallback
branch
from
38d6b12 to
774c9b3
Compare
AnikethCheluva
force-pushed
the
aidan/bounds-check
branch
from
0b6765d to
aad3d3a
Compare
Open
AnikethCheluva
force-pushed
the
aidan/bounds-check
branch
2 times, most recently
from
a73267a to
b34056d
Compare
AnikethCheluva
force-pushed
the
aniketh/bad-idx-fallback
branch
from
774c9b3 to
3b6cc3c
Compare
SimarKareer
force-pushed
the
aniketh/bad-idx-fallback
branch
from
3b6cc3c to
a4a7300
Compare
SimarKareer
force-pushed
the
aidan/bounds-check
branch
from
b34056d to
9add5df
Compare
SimarKareer
changed the base branch from
aniketh/bad-idx-fallback
to
graphite-base/285
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.