Fix cursor jumping when closing rank editor GUI#313
Merged
Conversation
closeScreen() was always called before displayGuiScreen(prevScreen), triggering setIngameFocus() which grabbed and centered the mouse. setCursorPosition then tried to restore the cursor but had inverted Y (LWJGL2 getY is bottom-origin, setCursorPosition is top-origin). Fixed by skipping closeScreen() when a previous screen is being opened, making cursor restoration unnecessary.
MassAnarchyy
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closeScreen() was always called before displayGuiScreen(prevScreen), which internally triggered setIngameFocus() and grabbed/centered the mouse. setCursorPosition then tried to restore the original position but was broken due to a LWJGL2 coordinate mismatch (getY() is bottom-origin, setCursorPosition expects top-origin), causing the cursor to land at a mirrored position (e.g. top-right click -> cursor ends up at bottom-right).
Fixed by skipping closeScreen() when a previous screen is being opened — the mouse is never grabbed so no restoration is needed.