Skip to content
This repository was archived by the owner on Jun 15, 2026. It is now read-only.

Show aspects in tooltip#33

Merged
Dream-Master merged 11 commits into
GTNH-Museum:masterfrom
slprime:fix_handlers
Feb 8, 2026
Merged

Show aspects in tooltip#33
Dream-Master merged 11 commits into
GTNH-Museum:masterfrom
slprime:fix_handlers

Conversation

@slprime

@slprime slprime commented Oct 25, 2025

Copy link
Copy Markdown

Aspect from ItemStack Handler

image

Alignment the handlers

before after
image image
image image
image image
image image

Other

  1. Add usege handler for items
  2. closed: Thaumcraft Aspects not showing in NEI. GTNewHorizons/GT-New-Horizons-Modpack#22117

@slprime slprime requested a review from a team October 25, 2025 17:09

@tomprince tomprince left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out, and it appears that with this the "Aspect from ItemStack" page in NEI only shows a single box of results (which is often not enough to show all stacks that give the given aspect). Previously, there would multiple boxes of items that have the given aspect.

@slprime

slprime commented Oct 29, 2025

Copy link
Copy Markdown
Author

I tested this out, and it appears that with this the "Aspect from ItemStack" page in NEI only shows a single box of results (which is often not enough to show all stacks that give the given aspect). Previously, there would multiple boxes of items that have the given aspect.

Give an example because I didn't change the list of items

@tomprince

Copy link
Copy Markdown

This is on 8.1:
image

After adding using the mod version built on github, I only get a page with the first box.

@slprime

slprime commented Oct 29, 2025

Copy link
Copy Markdown
Author

hm... i will check. thx

@slprime slprime requested a review from tomprince October 29, 2025 17:07
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta (experimental build) label Nov 14, 2025
@SuperSoupr

SuperSoupr commented Dec 16, 2025

Copy link
Copy Markdown

@slprime I also tested this and it seems that the tooltip for the second recipe doesn't show up when you hover over the icon
image

boubou19
boubou19 previously approved these changes Dec 16, 2025
@boubou19 boubou19 dismissed their stale review December 16, 2025 21:29

apparently i missed a bug

@boubou19

boubou19 commented Dec 16, 2025

Copy link
Copy Markdown

@slprime I also tested this and it seems that the tooltip for the second recipe doesn't show up when you hover over the icon image

does it change with gui scale?

@SuperSoupr

Copy link
Copy Markdown

does it change with gui scale?

No

@slprime

slprime commented Dec 16, 2025

Copy link
Copy Markdown
Author

@slprime I also tested this and it seems that the tooltip for the second recipe doesn't show up when you hover over the icon

fixed
image

@PLASMAchicken

Copy link
Copy Markdown
Image

In 2.7.4 it showed the aspects via Thaumcraft Implementation, but only if my curser was in the top 20% of the slot

@danyadev

danyadev commented Jan 5, 2026

Copy link
Copy Markdown

This doesn't fully fix the issue, it adds aspects only in TC handlers but not in other NEI interfaces (i.e. recipes, bookmarks, item list)

Also aspects are usually shown only when shift is pressed, now they're always visible

@slprime

slprime commented Jan 17, 2026

Copy link
Copy Markdown
Author

fixed:
image

Comment thread src/main/java/ru/timeconqueror/tcneiadditions/nei/AspectFromItemStackHandler.java Outdated
@danyadev

danyadev commented Feb 8, 2026

Copy link
Copy Markdown

for some reason on small window size the sensitive area is above the icon
image

@slprime slprime requested a review from danyadev February 8, 2026 20:38
Comment thread gradle.properties Outdated
@Dream-Master Dream-Master merged commit 5bf40c9 into GTNH-Museum:master Feb 8, 2026
1 check passed
@Dream-Master Dream-Master removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta (experimental build) label Feb 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thaumcraft Aspects not showing in NEI.

7 participants