This repository was archived by the owner on Jun 15, 2026. It is now read-only.
Format number migration#4
Merged
Merged
Conversation
added 3 commits
January 24, 2026 02:32
…n force other deps to update.
UltraProdigy
approved these changes
Jan 24, 2026
mitchej123
reviewed
Feb 14, 2026
| } | ||
| }; | ||
|
|
||
| public static String formatNumber(double value) { |
Contributor
There was a problem hiding this comment.
This should not have been merged. You're removing things from the public API that other mods rely upon. It should have either been marked deprecated, or forwarded to the new nhlib variants. Now draconic is crashing when I'm trying to test other things... 😡
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precursor for the Draconic evolution patch.