Closed
Conversation
jamesbraza
requested review from
MicPie,
albertbou92,
geemi725,
maykcaldas,
sidnarayanan and
whitead
There was a problem hiding this comment.
Pull Request Overview
This PR adds a missing unit test for the oracle_solubility_eval function, ensuring its behavior is validated across multiple scenarios.
- Imported the new
oracle_solubility_evalfunction into the test suite - Added a parameterized
test_oracle_solubility_evalcovering diverse solubility cases
Comments suppressed due to low confidence (1)
tests/test_rewards.py:361
- It may be valuable to add an assertion on
metadataafter callingoracle_solubility_evalto ensure expected metadata entries are populated.
metadata: dict[str, JsonValue] = {}
| ), f"Reason for failure: {metadata}" | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( |
There was a problem hiding this comment.
[nitpick] This long list of parameter cases could be refactored into a helper or fixture to reduce duplication and make individual cases easier to manage.
| ), | ||
| pytest.param( | ||
| "CCCCCC=CCCCN(C)CCC", | ||
| '("groups", ["cis double bond", "hetero N basic H"], -4.693881511688232, "decrease")', # noqa: E501 |
There was a problem hiding this comment.
[nitpick] There are two spaces before the numeric literal; consider normalizing whitespace to a single space for consistency.
Suggested change
| '("groups", ["cis double bond", "hetero N basic H"], -4.693881511688232, "decrease")', # noqa: E501 | |
| '("groups", ["cis double bond", "hetero N basic H"], -4.693881511688232, "decrease")', # noqa: E501 |
Collaborator
Author
|
Nevermind, I realized I put this test in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Realized I didn't open source a unit test that I could have