Claude/add progress callbacks #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a flexible callback system that allows users to monitor fzr execution progress programmatically. This is useful for building UIs, dashboards, and custom progress displays on top of fz. Features: - on_start: Called when fzr begins execution - on_case_start: Called when each case starts - on_case_complete: Called when each case finishes (success or failure) - on_progress: Called periodically with ETA estimates - on_complete: Called when all cases finish Implementation details: - Callbacks are optional (backwards compatible) - Callbacks are validated at call time - Errors in callbacks are caught and logged but don't crash execution - Thread-safe callback invocation in parallel execution mode - Comprehensive test suite covering all callback scenarios Changes: - fz/core.py: Added callbacks parameter to fzr(), validation, and on_start/on_complete calls - fz/helpers.py: Pass callbacks through execution chain, call on_case_start, on_case_complete, and on_progress - tests/test_callbacks.py: Comprehensive test suite with 6 test cases covering all functionality Tested: - All callback types fire correctly - Error handling prevents callback failures from crashing execution - Single case edge case - Thread safety with parallel execution - Input validation - Backwards compatibility (callbacks are optional)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.