[FIX] Fix calling instance inline functions of abstracts#334
Merged
EliteMasterEric merged 1 commit intoFunkinCrew:experimental-abstractsfrom Feb 16, 2026
Merged
Conversation
87eb833 to
d809fac
Compare
d878bc6 to
e142f43
Compare
lemz1
commented
Feb 8, 2026
| continue; | ||
| if (k != MethInline) continue; | ||
| if (abstractPath.startsWith('cpp')) continue; | ||
| if (abstractPath.startsWith('flixel.graphics.atlas.HashOrArray')) continue; // has to be ragebait |
Author
There was a problem hiding this comment.
HashOrArray seems to not work with the type parameter being Dynamic
if someone knows a fix or workaround please let me know
e5b7d8a to
274fa7c
Compare
Member
|
@lemz1 I rebased the |
e142f43 to
96ad169
Compare
Author
|
i hope i didnt break anything during the rebase |
EliteMasterEric
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes inline abstract functions that assign to
thisdirectly.script.hxc:
before:
after: