Conversation
5c37370 to
dbb1840
Compare
|
Hmm I just realized that in hxcpp if you try to get a value from a enum that doesn't exist it'll just return null, meanwhile my last commit made it so that in HashLink it throws an error. Maybe it should be reverted. |
|
Is this fully functional or still in testing? |
|
I guess it stills needs better parity with HXCPP (which I don't think will ever be 100% achievable) |
d7c5963 to
d05358a
Compare
8638713 to
eaaacd1
Compare
eaaacd1 to
38ba0e4
Compare
93a2de6 to
8318d9b
Compare
8318d9b to
43657d8
Compare
43657d8 to
0a7283c
Compare
7ebf32b to
6a46310
Compare
8521083 to
9c1ba6a
Compare
9c1ba6a to
a19bff2
Compare
|
I think this is good enough to at least be able to run FNF in HashLink. I don't think there's a way to fix all of the parity issues, so don't expect cross-target compatibility of mods to work. |
|
This PR is kind of in limbo since I can't get lime to build anything with hashlink right now 🤷 I'm also not too much of a fan of HashLink anyway so I can't really be bothered to put a lot of effort into this. |
|
That's understandable. But if you'd like to test it sometime, there's a list of all the necessary changes to run in the PRs listed in FunkinCrew/Funkin#6135, including a fix for the Lime build issue. |
Fixes some issues with HashLink: an error when trying to resolve abstracts, and a workaround for HaxeFoundation/hscript#96 by using a macro that creates a wrapper class for
StdandMath.Edit: Now also fixes enum values not being evaluated properly