ci: lock build-channel workflow installs#829
Merged
Merged
Conversation
PR SummaryLow Risk Overview Tests no longer depend on yesterday’s nightly publish. Override-based test helpers in Reviewed by Cursor Bugbot for commit 90e4bc7. Bugbot is set up for automated code reviews on this repo. Configure here. |
Contributor
zees-dev
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lock the
build-channelworkflow installs to the repository lockfile in the two workflows that install the helper binary:Publish Channel (nightly)Update ChannelWhy
The manual
Publish Channel (nightly)run failed on theInstall build-channel scriptstep before it ever reached channel publishing or deployment.Failing run:
The workflow currently runs:
cargo install --debug --path ./ci/build-channelBecause that install is not locked, Cargo re-resolves dependencies on the runner instead of honoring the repo lockfile. In the failing run it pulled newer
icu_* 2.2.0crates, which require Rust1.86, while the workflow is pinned to Rust1.85.0.The repo lockfile already pins the same dependency family to compatible
1.5.xversions, so this is dependency drift during CI install rather than a true project-wide Rust floor bump.Change
Add
--lockedto thecargo install --path ./ci/build-channelcommand in both workflows so CI uses the checked-in lockfile when installing the helper.Validation
Validated locally in Docker with
rust:1.85against this checkout:cargo install --debug --path ./ci/build-channelfailed and re-resolved toicu_* 2.2.0, which requires Rust1.86cargo install --locked --debug --path ./ci/build-channelsucceeded on the same toolchainThat matches the GitHub Actions failure and confirms
--lockedis the correct fix without widening the workflow toolchain unnecessarily.