-
-
Notifications
You must be signed in to change notification settings - Fork 38
feat(settings): complete the search index and give every row a symbol and subtext #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+111
−24
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import XCTest | ||
| @testable import Cotabby | ||
|
|
||
| /// Pins the hygiene rules of the Settings search index. The index drifts silently when a new | ||
| /// setting ships without an entry (it simply never appears in search), so these tests make the | ||
| /// cheap invariants loud: every item must carry a non-empty title, symbol, and keyword set, and | ||
| /// the queries users actually type for recently shipped settings must land on them. | ||
| final class SettingsIndexTests: XCTestCase { | ||
| func test_everyItemHasTitleSymbolAndKeywords() { | ||
| for item in SettingsItem.allCases { | ||
| XCTAssertFalse(item.title.isEmpty, "\(item) needs a title") | ||
| XCTAssertFalse(item.systemImage.isEmpty, "\(item) needs an SF Symbol") | ||
| XCTAssertFalse(item.keywords.isEmpty, "\(item) needs search keywords") | ||
| } | ||
| } | ||
|
|
||
| func test_itemIdsAreUnique() { | ||
| let ids = SettingsItem.allCases.map(\.id) | ||
| XCTAssertEqual(ids.count, Set(ids).count, "duplicate SettingsItem ids break Identifiable lists") | ||
| } | ||
|
|
||
| func test_searchFindsRecentlyShippedSettings() { | ||
| // Each pair pins one real query for a setting that previously shipped without an index | ||
| // entry. If one of these fails, a rename or removal broke search for that setting. | ||
| let expectations: [(query: String, item: SettingsItem)] = [ | ||
| ("ghost text size", .ghostTextSize), | ||
| ("terminal", .suggestInIntegratedTerminals), | ||
| ("vscode", .suggestInIntegratedTerminals), | ||
| ("typo", .automaticallyFixTypos), | ||
| ("model status", .modelStatus), | ||
| ("battery", .batteryModel), | ||
| ("plugged", .pluggedInModel) | ||
| ] | ||
| for expectation in expectations { | ||
| XCTAssertTrue( | ||
| SettingsItem.results(for: expectation.query).contains(expectation.item), | ||
| "query \"\(expectation.query)\" should surface \(expectation.item)" | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| func test_blankQueryReturnsNothing() { | ||
| XCTAssertTrue(SettingsItem.results(for: " ").isEmpty) | ||
| XCTAssertTrue(SettingsItem.results(for: "").isEmpty) | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.