Feat: Azure Blob Storage File Storage Plugin#344
Open
degenone wants to merge 9 commits intoFritzAndFriends:v0.7from
Open
Feat: Azure Blob Storage File Storage Plugin#344degenone wants to merge 9 commits intoFritzAndFriends:v0.7from
degenone wants to merge 9 commits intoFritzAndFriends:v0.7from
Conversation
…r improved file handling and migration support
…agement and navigation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I continued vibe coding and decided to take on #227. It turned out to be more work than expected but it seems to be working now.
I needed to touch on #195 to define the NuGet dependencies for the plugin.
{ ... "NuGetDependencies": [ { "Package": "Azure.Storage.Blobs", "Version": "12.19.1" }, { "Package": "Azure.Core", "Version": "1.44.1" }, ... ] }To get the plugin to build with the DLLs I had to add
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>to the projects.csprojfile. Is there a better way?PluginPackertool now looks at the manifest property to search and copy the dependencies to the.sspkgpackage.I also needed a way to remove the
FileStorage.FileSystemplugin so I had to implement #118.PluginManager.RemovePluginand the changes toSharpSite.Pluginsare where I most relied on Copilot, so this could use a careful code review.There is now a warning in Plugin Management page if you have no or more than 1 plugins with
FileStoragefeature is installed.The error when you have no
FileStorageplugin installed and try to add an image is not very useful atm.