FreeCADWeb.Org ➞ FreeCAD.Org#7
Conversation
hyarion
left a comment
hyarion
left a comment
There was a problem hiding this comment.
Note that while domains don't mind casing, the web server changes it automatically to lowercase - as the rest of the internet.
I'd say keep it lowercase
|
also server seem to add |
|
Thats not the server, thats your browser. ( Btw the browser doesn't even make any redirects for that ) |
|
The discussion continues in FreeCAD/FreeCAD-Homepage#263 |
|
In the developer discussion held
|
yorikvanhavre
left a comment
yorikvanhavre
left a comment
There was a problem hiding this comment.
Good for me! Since @hyarion has requested changes, I'll let him review and merge
hyarion
left a comment
hyarion
left a comment
There was a problem hiding this comment.
The spinner can be dropped but looks good otherwise
| @@ -1,10 +1,10 @@ | |||
| # <img src="https://freecadweb.org/images/logo.png" style="zoom:33%;" /> FreeCAD documentation rewrite | |||
| # <img src="https://www.freecad.org/images/loader-freecad.gif" height="24" /> FreeCAD documentation rewrite | |||
There was a problem hiding this comment.
How about dropping the use of the image mark here?
The usage wasn't warranted in the first place and it didn't really follow the guidelines for the text mark portion of the logo either.
The loader is neat for showing when stuff is loading, but it shouldn't be used arbitrary as it makes it a bit distracting.
There was a problem hiding this comment.
How is this relevant to the PR?
This PR changes just one type of thing for a reason,
if you want to have the layout modified, that should
be done in a dedicated PR afterwards.
4 participants
This PR updates references to the
old FreeCAD site with new ones.
I also substituted the broken logo link in the
manifest with the animated version of the logo.
FYI, domains don't mind the casing.