Skip to content

“Done” button in the Today view #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrankFaulstich merged 1 commit into from
May 12, 2026
Merged

“Done” button in the Today view #404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 103 additions & 3 deletions sl/SL_Menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,38 @@ def view_task_planning():
"""
render_header(_("Task Planning"))

# Custom CSS for square action buttons in the task list
st.markdown("""
<style>
/* Target horizontal blocks that contain the task rows */
[data-testid="stMainView"] [data-testid="stHorizontalBlock"] {
display: flex !important;
flex-direction: row !important;
flex-wrap: nowrap !important;
align-items: flex-start !important;
gap: 0.5rem !important;
}
/* Ensure the info column takes remaining space */
[data-testid="stMainView"] [data-testid="stHorizontalBlock"] [data-testid="column"]:nth-child(1) {
flex: 1 1 auto !important;
min-width: 0 !important;
}
/* Fixed width for the three button columns (Play, Edit, Done) */
[data-testid="stMainView"] [data-testid="stHorizontalBlock"] [data-testid="column"]:nth-child(2),
[data-testid="stMainView"] [data-testid="stHorizontalBlock"] [data-testid="column"]:nth-child(3),
[data-testid="stMainView"] [data-testid="stHorizontalBlock"] [data-testid="column"]:nth-child(4) {
flex: 0 0 50px !important;
width: 50px !important;
min-width: 50px !important;
}
[data-testid="stMainView"] [data-testid="stHorizontalBlock"] [data-testid="column"] button {
width: 50px !important;
height: 48px !important;
padding: 0 !important;
}
</style>
""", unsafe_allow_html=True)

filter_options = [
_("Today"),
_("Tomorrow"),
Expand Down Expand Up @@ -285,7 +317,7 @@ def view_task_planning():
st.subheader(weekday_names[day_idx])
# Layout für jede Aufgabe mit Bearbeiten-Button
for t_idx, task in enumerate(tasks_by_day[day_idx]):
col_task, col_start_btn, col_edit_btn = st.columns([10, 1, 1])
col_task, col_start_btn, col_edit_btn, col_done_btn = st.columns([10, 1, 1, 1])
with col_task:
name = task['task_name']
is_active = current_work and current_work['main_project_name'] == task['main_project_name'] and current_work['task_name'] == task['task_name']
Expand All @@ -312,14 +344,26 @@ def view_task_planning():
st.session_state.context['selected_task_id'] = task.get('id')
st.session_state.context['return_to'] = 'task_planning'
navigate_to('edit_task_form')
with col_done_btn:
if st.button("✔", key=f"done_task_planning_weekly_{task['main_project_name']}_{task['task_name']}_{t_idx}", help=_("Done"), disabled=is_done):
st.session_state.tracker.update_task(
task['main_project_name'],
task['task_name'],
status='done',
recurring=task.get('recurring'),
frequency=task.get('frequency'),
userdefined_days=task.get('userdefined_days'),
task_id=task.get('id'),
)
st.rerun()
else:
current_main = None
for t_idx, task in enumerate(tasks):
if task['main_project_name'] != current_main:
current_main = task['main_project_name']
st.subheader(current_main)

col_task, col_start_btn, col_edit_btn = st.columns([10, 1, 1])
col_task, col_start_btn, col_edit_btn, col_done_btn = st.columns([10, 1, 1, 1])
with col_task:
name = task['task_name']
status = task.get('status')
Expand Down Expand Up @@ -348,6 +392,18 @@ def view_task_planning():
st.session_state.context['selected_task_id'] = task.get('id')
st.session_state.context['return_to'] = 'task_planning'
navigate_to('edit_task_form')
with col_done_btn:
if st.button("✔", key=f"done_task_planning_{task['main_project_name']}_{task['task_name']}_{t_idx}", help=_("Done"), disabled=is_done):
st.session_state.tracker.update_task(
task['main_project_name'],
task['task_name'],
status='done',
recurring=task.get('recurring'),
frequency=task.get('frequency'),
userdefined_days=task.get('userdefined_days'),
task_id=task.get('id'),
)
st.rerun()
else:
st.info(_("No tasks found."))

Expand All @@ -360,6 +416,38 @@ def view_today_tasks():
"""
render_header(_("Today's Tasks"))

# Custom CSS for square action buttons in the task list
st.markdown("""
<style>
/* Target horizontal blocks that contain the task rows */
[data-testid="stMainView"] [data-testid="stHorizontalBlock"] {
display: flex !important;
flex-direction: row !important;
flex-wrap: nowrap !important;
align-items: flex-start !important;
gap: 0.5rem !important;
}
/* Ensure the info column takes remaining space */
[data-testid="stMainView"] [data-testid="stHorizontalBlock"] [data-testid="column"]:nth-child(1) {
flex: 1 1 auto !important;
min-width: 0 !important;
}
/* Fixed width for the three button columns (Play, Edit, Done) */
[data-testid="stMainView"] [data-testid="stHorizontalBlock"] [data-testid="column"]:nth-child(2),
[data-testid="stMainView"] [data-testid="stHorizontalBlock"] [data-testid="column"]:nth-child(3),
[data-testid="stMainView"] [data-testid="stHorizontalBlock"] [data-testid="column"]:nth-child(4) {
flex: 0 0 50px !important;
width: 50px !important;
min-width: 50px !important;
}
[data-testid="stMainView"] [data-testid="stHorizontalBlock"] [data-testid="column"] button {
width: 50px !important;
height: 48px !important;
padding: 0 !important;
}
</style>
""", unsafe_allow_html=True)

st.session_state.tracker.cleanup_overdue_today_tasks()
current_work = st.session_state.tracker.get_current_work()

Expand All @@ -379,7 +467,7 @@ def view_today_tasks():
for main_proj_name, sub_tasks in today_tasks_grouped.items(): # Grouped by main project
st.subheader(main_proj_name)
for t_idx, task in enumerate(sub_tasks): # Iterate through tasks in the group
col_task, col_start_btn, col_edit_btn = st.columns([10, 1, 1])
col_task, col_start_btn, col_edit_btn, col_done_btn = st.columns([10, 1, 1, 1])
with col_task:
name = task['task_name']
status = task.get('status')
Expand Down Expand Up @@ -407,6 +495,18 @@ def view_today_tasks():
st.session_state.context['selected_task_id'] = task.get('id')
st.session_state.context['return_to'] = 'today_view'
navigate_to('edit_task_form')
with col_done_btn:
if st.button("✔", key=f"done_today_task_{task['main_project_name']}_{task['task_name']}_{t_idx}", help=_("Done"), disabled=is_done):
st.session_state.tracker.update_task(
task['main_project_name'],
task['task_name'],
status='done',
recurring=task.get('recurring'),
frequency=task.get('frequency'),
userdefined_days=task.get('userdefined_days'),
task_id=task.get('id'),
)
st.rerun()
else:
st.info(_("No tasks for today."))

Expand Down
Loading